[SYCL] Add tests for atomic_fence_capabilities. #8853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maronas, Marcos <[email protected]>
bader
reviewed
Mar 30, 2023
Comment on lines
3
to
18
| #include <algorithm> | ||
| #include <sycl/sycl.hpp> | ||
|
|
||
| using namespace sycl; | ||
|
|
||
| bool is_supported_order(const std::vector<memory_order> &capabilities, | ||
| memory_order mem_order) { | ||
| return std::find(capabilities.begin(), capabilities.end(), mem_order) != | ||
| capabilities.end(); | ||
| } | ||
|
|
||
| bool is_supported_scope(const std::vector<memory_scope> &capabilities, | ||
| memory_scope mem_scope) { | ||
| return std::find(capabilities.begin(), capabilities.end(), mem_scope) != | ||
| capabilities.end(); | ||
| } |
There was a problem hiding this comment.
Please, move this code to the cpp file. Having function definitions in a header file is fraught with problems.
Signed-off-by: Maronas, Marcos <[email protected]>
bader
changed the title
bader
added a commit
that referenced
this pull request
Apr 1, 2023
Reverts #8853 Committed by mistake. New test fails on NVIDIA GPU.
|
@maarquitos14, sorry, I merged this PR by mistake. |
The PR is already created, I'm waiting for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds E2E tests for
sycl::info::device::atomic_fence_order_capabilitiesandsycl::info::device::atomic_fence_scope_capabilities.