[SYCL] Cache kernel assert usage #18538
Open
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Pennycook
reviewed
May 19, 2025
Comment on lines
+365
to
+366
| if (!KernelNameBasedCachePtr) | ||
| return m_KernelUsesAssert.find(KernelName) != m_KernelUsesAssert.end(); |
There was a problem hiding this comment.
What conditions could lead to us having a kernel name but no cache associated with it?
There was a problem hiding this comment.
An application that hasn't been recompiled since the cache was added to the headers.
There was a problem hiding this comment.
Oh, wow, okay.
Would it make sense to mark this as #ifndef __INTEL_PREVIEW_BREAKING_CHANGES? My thinking is:
- An application must recompile to use the preview library, and will need to recompile after the ABI break;
- In the case where somebody has recompiled, we can skip a branch; and
- Decorating this with the
#ifdefwill make sure it gets taken out at the next ABI break.
There was a problem hiding this comment.
Sure, I think it makes sense. Since this is also applicable to the UR kernel cache logic introduced by the original cache PR, I'd rather apply this to both in a separate PR.
Pennycook
reviewed
May 19, 2025
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache whether a kernel uses assertions or not to avoid a set lookup.