[libspirv] Move unsigned atomic built-ins to generic #18532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to PR intel#18328, unsigned variant has the same implementation as signed variant for most of the atomic built-ins. Move unsigned implementations to generic to simplify target-specific code.
frasercrmck
approved these changes
May 19, 2025
There was a problem hiding this comment.
LGTM. I'm a little concerned about the discoverability of the signed vs. unsigned split, and whether developers will intuitively understand why there aren't custom unsigned implementations for AMD, for example. The file name based overriding can be tricky to follow. I don't think this holds up the PR but it might be something to think about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PR #18328, unsigned variant has the same implementation as signed variant for most of the atomic built-ins.
Move unsigned implementations to generic to simplify target-specific code.