Skip to content

[SYCL] deprecate ext_oneapi_get_last_event and ext_oneapi_set_externa… #18494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

igchor
Copy link
Member

@igchor igchor commented May 15, 2025

…l_event

@igchor igchor force-pushed the deprecate_in_order_events branch from 9f542ed to d93cc3d Compare May 15, 2025 20:48
@igchor igchor force-pushed the deprecate_in_order_events branch from d93cc3d to cbfc700 Compare May 15, 2025 20:57
@igchor igchor force-pushed the deprecate_in_order_events branch from cbfc700 to 775943b Compare May 15, 2025 23:28
@igchor igchor temporarily deployed to WindowsCILock May 15, 2025 23:28 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 15, 2025 23:55 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 15, 2025 23:55 — with GitHub Actions Inactive
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this extension is used as an implementation detail of async_malloc https://github.com/intel/llvm/blob/sycl/sycl/source/detail/async_alloc.cpp#L84

So if we're depreciating it, then we should update that implementation, or create an issue to do so and reference it in a comment next to that line of code.

@igchor
Copy link
Member Author

igchor commented May 16, 2025

FYI this extension is used as an implementation detail of async_malloc https://github.com/intel/llvm/blob/sycl/sycl/source/detail/async_alloc.cpp#L84

So if we're depreciating it, then we should update that implementation, or create an issue to do so and reference it in a comment next to that line of code.

That's a good point. I'll take a look at how we can modify the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants