-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][NFC] Add E2E test for gpu AOT to JIT fallback #18492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
KseniyaTikhomirova
wants to merge
5
commits into
intel:sycl
Choose a base branch
from
KseniyaTikhomirova:add_tests_for_aot2jit
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[SYCL][NFC] Add E2E test for gpu AOT to JIT fallback #18492
KseniyaTikhomirova
wants to merge
5
commits into
intel:sycl
from
KseniyaTikhomirova:add_tests_for_aot2jit
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
maarquitos14
approved these changes
May 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nit.
@jzc can you take a look at this? |
Co-authored-by: Marcos Maronas <[email protected]>
jzc
approved these changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the feature of AOT to JIT fallback was implemented and enabled in this commit 38e588d
commit includes UT for jit fallback for kernel compiled for older platform 38e588d
this fallback works when
-fsycl-targets
is set for compilation and AOT images contain info about architecture it is built for. In order to build program SYCL RT choose images by compile target (if property is set) and adds spirv (if available) to the image set passed to backend later.Choice what image to use is done in UR adapter for specific backend. Where it chooses AOT image if available and uses SPIRV as fallback.
While RT part is completely tested by UT, adding small E2E test to verify stack behavior.