Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Driver] '-fsycl-unnamed-lambda' is not supported with '-fsycl-host-compiler' #17840

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

srividya-sundaram
Copy link
Contributor

@srividya-sundaram srividya-sundaram commented Apr 3, 2025

Addresses #15120

This patch emits an error when -fsycl-unnamed-lambda is used in conjunction with -fsycl-host-compiler
Also, use of -fsycl-host-compiler implicitly adds -fno-sycl-unnamed-lambda to the list of command line arg strings.

@srividya-sundaram srividya-sundaram marked this pull request as ready for review April 4, 2025 16:41
@srividya-sundaram srividya-sundaram requested a review from a team as a code owner April 4, 2025 16:41
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@srividya-sundaram srividya-sundaram changed the title [SYCL][Driver] '-fsycl-unnamed-lambda' is not supported with '-fsycl-… [SYCL][Driver] '-fsycl-unnamed-lambda' is not supported with '-fsycl-host-compiler' Apr 4, 2025
@srividya-sundaram
Copy link
Contributor Author

The error seems unrelated to my change: Error: File was unable to be removed Error: EACCES: permission denied, unlink '/__w/llvm/llvm/build-e2e-new/-'

@intel/llvm-gatekeepers This is ready for merge. Thanks!

@martygrant martygrant merged commit 6176b29 into intel:sycl Apr 7, 2025
56 of 59 checks passed
ggojska pushed a commit to ggojska/llvm that referenced this pull request Apr 7, 2025
…host-compiler' (intel#17840)

Addresses intel#15120

This patch emits an error when `-fsycl-unnamed-lambda` is used in
conjunction with `-fsycl-host-compiler`
Also, use of `-fsycl-host-compiler` implicitly adds
`-fno-sycl-unnamed-lambda` to the list of command line arg strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants