Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] add v2 adapter to preloadLibraries() #17839

Merged
merged 3 commits into from
Apr 4, 2025

Conversation

igchor
Copy link
Member

@igchor igchor commented Apr 3, 2025

No description provided.

@igchor igchor requested a review from a team as a code owner April 3, 2025 21:25
@igchor igchor requested a review from aelovikov-intel April 3, 2025 21:25
@igchor igchor temporarily deployed to WindowsCILock April 3, 2025 21:25 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 3, 2025 21:39 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 3, 2025 21:39 — with GitHub Actions Inactive
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this file be owned by UR team?

@igchor igchor temporarily deployed to WindowsCILock April 4, 2025 15:53 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 4, 2025 16:25 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock April 4, 2025 16:25 — with GitHub Actions Inactive
@igchor
Copy link
Member Author

igchor commented Apr 4, 2025

@intel/llvm-gatekeepers this is ready to be merged.

@aelovikov-intel I'm not sure about the ownership, this is part of SYCL's logic for handling UR adapters lifetimes

@uditagarwal97 uditagarwal97 merged commit 1f5e50a into intel:sycl Apr 4, 2025
26 of 36 checks passed
ggojska pushed a commit to ggojska/llvm that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants