This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][Matrix]Add test for odd sizes #1523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // RUN: %CPU_RUN_PLACEHOLDER %t.out | ||
| // RUN: %GPU_RUN_PLACEHOLDER %t.out | ||
|
|
||
| // XFAIL: gpu |
There was a problem hiding this comment.
could you please clarify what is the reason for xfail on gpu? Is there lack of support?
There was a problem hiding this comment.
Yes, there is lack of support of these sizes on the GPU
| // init_and_multiply<int8_t, int32_t, 4, 5, 16, 32>(); | ||
| // init_and_multiply<int8_t, int32_t, 4, 6, 16, 32>(); | ||
| // init_and_multiply<int8_t, int32_t, 4, 7, 16, 32>(); | ||
| // init_and_multiply<int8_t, int32_t, 4, 8, 16, 32>(); |
There was a problem hiding this comment.
why do we have many lines commented out? What we need/wait to enable them?
There was a problem hiding this comment.
I uncommented them. All these calls with different sizes need support to remove the xfail
mbelicki
suggested changes
Feb 28, 2023
| for (int i = 0; i < MATRIX_M; i++) { | ||
| for (int j = 0; j < MATRIX_N; j++) { | ||
| if constexpr (std::is_same_v<Ta, bfloat16> && std::is_same_v<Tc, float>) { | ||
| if ((fabs(C[i][j]) - fabs(D[i][j])) > BF16_EPSILON) { |
There was a problem hiding this comment.
It should be: "(fabs(C[i][j] - D[i][j])) > BF16_EPSILON" otherwise the test will always pass when values in C are smaller or equal to those in D.
|
was replaced by #1628 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.