Improvements to documentation and code adjustments for compatibility with GCC and Clang #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Updated Readme.txt:
Improved clarity for better readability.
Fixed incorrect paths in the Ubuntu installation instructions.
Code Adjustments
CMakeLists.txt:
Removed the -Wno-unqualified-std-cast-call flag, as it is not supported by GCC 13.3 or Clang 16.
ActiveRelationshipTableEntry.h and ThermalRelationshipTableEntry.h:
Explicitly introduced using RelationshipTableEntryBase::operator==; to resolve a hidden overload issue and to make the operator usage more explicit.
Motivation
The Readme.txt updates ensure that developers can correctly follow the instructions for Ubuntu without confusion.
Removing the unsupported flag from CMakeLists.txt ensures a seamless build process with both GCC and Clang.
Explicitly declaring the operator in the header files resolves hidden overload warnings and improves code clarity and maintainability.