Skip to content

feat(checker): add fish checker #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Conversation

ffontaine
Copy link
Contributor

No description provided.

@terriko
Copy link
Contributor

terriko commented Jun 27, 2025

Bumped the branch on this one just to see where the tests are at today.

@ffontaine
Copy link
Contributor Author

They fails due to OSV on:

=========================== short test summary info ============================
FAILED test/test_source_purl2cpe.py::TestSourceOSV::test_db_contents[1-False] - AssertionError: Missing elements in database: ['pkg:1234n/minicms', 'pkg:13thmonkey/udfclient', 'pkg:23systems/lightbox-plus-for-wordpress', 'pkg:2glux/sexypolling', 'pkg:2pisoftware/cmfive']
assert not ['pkg:1234n/minicms', 'pkg:13thmonkey/udfclient', 'pkg:23systems/lightbox-plus-for-wordpress', 'pkg:2glux/sexypolling', 'pkg:2pisoftware/cmfive']
=========== 1 failed, 295 passed, 2043 skipped in 137.43s (0:02:17) ============

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex "fish-([0-9]+.[0-9]+.[0-9]+)" doesn't catch the packages fish_3.1.2-3+deb11u1_amd64.deb or fish_3.1.0-1_x86_64.ipk because they have a "" after the string "fish" and your regex only matches if a "-" follows "fish". I tried this regex "fish-|([0-9]+.[0-9]+.[0-9]+)" and it seems to catch all 4 packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed, so IMHO no need to update regex

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to @terriko and it looks like using a python regex checker may not match exactly what's going on when you're running it. So I'm going to build it today and get back to you after I've checked it. Thanks for your patience

Signed-off-by: Fabrice Fontaine <[email protected]>
@ffontaine
Copy link
Contributor Author

All tests passed and @brandonmarken approved the changes so merging

@ffontaine ffontaine merged commit fe94c15 into intel:main Jul 18, 2025
24 checks passed
@ffontaine ffontaine deleted the add-fish-checker branch July 18, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants