lib: remove ffi from default features #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psurply
force-pushed
the
dev/optional_cbindgen
branch
2 times, most recently
from
173cce9 to
e27f3b1
Compare
cbindgen is now added as a build dependency only when the "ffi" feature is enabled. This reduces the amount of build dependencies required to build the applications. Signed-off-by: Surply, Pierre <[email protected]>
psurply
force-pushed
the
dev/optional_cbindgen
branch
from
e27f3b1 to
7695511
Compare
jlrivasp
approved these changes
Mar 12, 2025
Contributor
jlrivasp
left a comment
jlrivasp
left a comment
There was a problem hiding this comment.
thanks a lot for the PR, it looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cbindgen is now added as a build dependency only when the "ffi" feature is enabled. This reduces the amount of build dependencies required to build the applications.