lib: improve warning message reported for empty records #8
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psurply
force-pushed
the
dev/empty_record_warning
branch
from
587b07b to
13b6851
Compare
When a record with an empty size is decoded, the warning message reported was rather confusing as it didn't include the type of the invalid record. Signed-off-by: Surply, Pierre <[email protected]>
psurply
force-pushed
the
dev/empty_record_warning
branch
from
13b6851 to
febeb3c
Compare
jlrivasp
approved these changes
Mar 17, 2025
Contributor
jlrivasp
left a comment
jlrivasp
left a comment
There was a problem hiding this comment.
Thanks a lot for the patch, it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a record with an empty size is decoded, the warning message reported was rather confusing as it didn't include the type of the invalid record.