lib: handle empty regions #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The box record payload does not always contain data. Checking if the
region is empty during its construction prevents the invalid box payload
to appear in the region list stored in the Crash Log struct.
This also prevents the unpack command to report empty regions and the
decode function to consider empty files as valid.
$ touch empty.crashlog
$ iclg decode empty.crashlog
Fatal Error: The Crash Log Region is not populated
Signed-off-by: Surply, Pierre <[email protected]>
psurply
force-pushed
the
dev/empty_region
branch
from
60c2709 to
6daf880
Compare
jlrivasp
approved these changes
Jun 18, 2025
Contributor
jlrivasp
left a comment
jlrivasp
left a comment
There was a problem hiding this comment.
It looks good to me, thanks a lot for the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The box record payload does not always contain data. Checking if the region is empty during its construction prevents the invalid box payload to appear in the region list stored in the Crash Log struct.
This also prevents the unpack command to report empty regions and the decode function to consider empty files as valid.