lib: add support for extraction from intel_pmt sysfs #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psurply
force-pushed
the
dev/pmt
branch
3 times, most recently
from
8fa9079 to
61516d5
Compare
jlrivasp
reviewed
Jul 4, 2025
Contributor
jlrivasp
left a comment
jlrivasp
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR, It looks good to me.
I just have a comment regarding the current from_linux_sysfs() API.
jlrivasp
reviewed
Jul 15, 2025
The Crash Log regions that are exposed by Intel PMT are accessible through the linux sysfs. The linux extraction function implemented in the library is being updated to look for any valid records that can be found in the ACPI tables and PMT structures. Signed-off-by: Surply, Pierre <[email protected]>
jlrivasp
reviewed
Jul 15, 2025
jlrivasp
approved these changes
Jul 15, 2025
Contributor
jlrivasp
left a comment
jlrivasp
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR, it looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Crash Log regions that are exposed by Intel PMT are accessible through the linux sysfs.
The linux extraction function implemented in the library is being updated to look for any valid records that can be found in the ACPI tables and PMT structures.