Skip to content

Conversation

@pmartindev
Copy link
Collaborator

@pmartindev pmartindev commented Nov 11, 2025

Resolves #1226


Before the change?

  • Rate limits would only output to [DEBUG] output. It would appear that the provider was hanging when under a rate limit.

After the change?

  • Output is changed to [INFO] and will always be output if a rate limit is hit

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Fixes integrations#1226

Previously, rate limit messages were only logged at DEBUG level,
causing the provider to appear to hang without feedback when rate
limited. This change adds INFO level logging that is visible by
default, informing users when:

- GitHub abuse detection is triggered
- API rate limits are reached

Users will now see messages indicating the provider is waiting
and will retry, rather than appearing frozen.
@pmartindev pmartindev changed the title Add INFO level logging for rate limit events fix: Add INFO level logging for rate limit events Nov 11, 2025
@stevehipwell
Copy link
Collaborator

@pmartindev have you tested this change?

@pmartindev pmartindev marked this pull request as draft November 12, 2025 15:54
@pmartindev
Copy link
Collaborator Author

pmartindev commented Nov 12, 2025

@stevehipwell no I haven't yet. This one will be somewhat challenging to manually test 😅 I thought we would have a discussion on if this is meets the criteria for solving the initial issue. Do we want to change how rate limits are output, or do we want to continue to only output this as debug output? I think there's an argument for both, and the solution may just be to "switch to debug mode" to validate rate limits.

I'm also not sure if there is a broader discussion on if we should update from the legacy logging system https://developer.hashicorp.com/terraform/plugin/log/writing#legacy-logging

@stevehipwell
Copy link
Collaborator

@pmartindev I suspect that you wont see the logs even after your change as the default provider log configuration is none and I think this applies to the legacy pattern.

@nickfloyd nickfloyd added this to the v6.x version wrap up milestone Nov 20, 2025
@nickfloyd nickfloyd moved this from Backlog to In Review in Terraform Provider Nov 20, 2025
@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Provider hangs, without giving any logging or feedback

3 participants