Fix assignment submission history being out of order #3435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Also let me know if I should sign a CLA because I haven't been prompted for one. |
Collaborator
|
After reproducing the issue, it only affects quizzes. This change would break the sorting on all other submission types. We add this bug to our backlog and it will be fixed in a future release. Thanks for the contribution and reporting the bug to us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes instructure/canvas-lms#2559.
The issue is that the API is already returning submission history in reverse chronological order, but the app reverses the submissions again, and then the attempt numbers don't line up.
Try this API endpoint with
?include=submission_historyon an assignment with multiple submissions from a student, and you'll see that the submissions are in reverse chronological order already.Note that I don't know how to test this change so it may not work, and no tests have been updated. Please make changes to this PR as necessary.
Happy holidays!