[MBL-19568][Student] Fix folder bookmarking and quiz routing #3431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable bookmarking for non-root folders to prevent routing issues with embedded links - Add route for new quizzes opened from quiz list to Assignment Details Test Plan: - Verify bookmarking is only available in root folder - Verify new quizzes route to Assignment Details correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR fixes the bookmarking behavior for file lists and adds routing support for new quizzes from the quiz list. The changes are focused and address specific navigation issues.
Issues Found
- Route pattern syntax error in
RouteMatcher.kt:408- Missing leading/in route pattern which may prevent URLs from matching correctly
Positive Feedback
FileListFragment.kt:
- Good fix for the bookmark behavior - adding the
folder?.isRoot == truecheck ensures that only root folder views in courses/groups are bookmarkable, which is the appropriate UX behavior - The null-safe navigation operator usage (
folder?.isRoot) is correct and handles the case where folder might be null
RouteMatcher.kt:
- The comment explaining the purpose of the new route is helpful for future maintainers
- The route correctly maps QuizListFragment → AssignmentDetailsFragment for new quizzes, which aligns with the architecture where new quizzes are displayed on assignment details
Code Quality
- Changes follow existing patterns in the codebase
- Code is concise and focused on the specific issues being addressed
- Null safety is properly handled with the safe call operator
Testing Recommendations
While no test files were modified, consider:
- Manual testing of bookmarking file list views in courses/groups at root and non-root levels
- Manual testing of navigation from quiz list to new quiz assignment details
- Verifying the route pattern matches expected URLs once the syntax issue is fixed
apps/student/src/main/java/com/instructure/student/router/RouteMatcher.kt
Show resolved
Hide resolved
📊 Code Coverage Report
|
🧪 Unit Test Results✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Thu, 04 Dec 2025 15:01:20 GMT |
kristofnemere
approved these changes
Dec 5, 2025
|
Student Install Page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan:
In the ticket
refs: MBL-19568
affects: Student
release note: Fixed folder and quiz bookmarking.
Checklist
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]