Skip to content

Conversation

@hickeyma
Copy link
Member

Add unit tests for taxonomy and model family.

@mergify mergify bot added testing Relates to testing ci-failure labels Jul 23, 2024
@hickeyma hickeyma force-pushed the tests/add-unit-tests branch from 702c43a to 79d48a9 Compare July 23, 2024 15:03
@mergify mergify bot removed the ci-failure label Jul 23, 2024
@hickeyma hickeyma requested a review from markmc July 24, 2024 08:23
Copy link
Contributor

@markmc markmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hickeyma just a couple of comments on the taxonomy test

Signed-off-by: Martin Hickey <[email protected]>
@hickeyma hickeyma force-pushed the tests/add-unit-tests branch from 79d48a9 to 2cccdaf Compare July 25, 2024 15:53
- Extended mock taxonomy to accept contents passed only
- Fixed the testing of the leaf node created for leaf node name
and check for seed example contained

Signed-off-by: Martin Hickey <[email protected]>
@hickeyma
Copy link
Member Author

Thanks for review @markmc. Updated and ready for review again.

@hickeyma hickeyma requested a review from markmc July 26, 2024 10:28
Copy link
Contributor

@markmc markmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hickeyma !

@markmc markmc added this to the 0.2.2 milestone Jul 26, 2024
@markmc markmc changed the title tests: Add unit tests tests: Add unit tests for taxonomy and model family Jul 26, 2024
@markmc markmc merged commit 7581308 into instructlab:main Jul 26, 2024
@hickeyma hickeyma deleted the tests/add-unit-tests branch July 29, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants