Skip to content

Conversation

Copy link

Copilot AI commented Jan 23, 2026

Pimcore 12 and CoreShop 5 Compatibility Update

  • Update composer.json to require:
    • pimcore/pimcore: ^12.3 (from ^11.0)
    • pimcore/admin-ui-classic-bundle: ^2.0 (from ^1.4)
    • coreshop/pimcore-bundle: ^5.0 (from ^4.0)
    • coreshop/resource-bundle: ^5.0 (from ^4.0)
    • coreshop/rule-bundle: ^5.0 (from ^4.0)
    • php: ^8.3 (from >=8.1)
  • Update GitHub Actions workflows:
    • Update behat.yml to use Pimcore 12.3 matrix and PHP 8.3
    • Update static.yml to use Pimcore 12.3 matrix and PHP 8.3
    • Update codestyles.yml branch references to 5.0 and PHP 8.3
  • Add Pimcore Studio React UI (ExtJS to React conversion):
    • Added pimcore-studio assets directory with React/TypeScript components
    • Created module federation setup with rsbuild for Pimcore Studio integration
    • Implemented ImportDefinitionsPanel and ExportDefinitionsPanel components
    • Implemented ImportDefinitionEditor and ExportDefinitionEditor with form handling
    • Added API service for definition CRUD operations with proper error handling
    • Added icon library module for Data Definitions icons
    • Added menu module for Settings navigation integration
    • Added TypeScript type definitions for definitions and mappings
    • Added input validation and sanitization
    • Moved package.json, rsbuild.config.ts, and tsconfig.json to root folder
  • Add Docker configuration for Pimcore Studio:
    • Added docker-compose.yaml.dist with services for PHP, Nginx, MySQL, OpenSearch, and Mercure
    • Added .docker/nginx.conf with Mercure proxy configuration for SSE
    • Added .docker/supervisord.conf for messenger queue workers
    • Added Dockerfile for development environment
    • Added config/packages/pimcore_studio_backend.yaml for Mercure settings
    • Added config/packages/pimcore_generic_data_index.yaml for OpenSearch settings
    • Updated .env with OpenSearch and Mercure environment variables
  • Add GitHub Action for frontend build:
    • Added frontend-build.yaml workflow that builds Studio bundle on every push
    • Automatically commits built assets back to the repository
    • Removed Studio build output from .gitignore so assets are tracked
  • Request code review
  • Run security scanning (no alerts found)
Original prompt

This section details on the original issue you should resolve

<issue_title>Update to Pimcore 12</issue_title>
<issue_description>Hello @dpfaffenbauer and team,

Not an issue but how about updating pimcore-data-definitions to Pimcore 12 ?

Will it be a big rework or only a composer packages update ?

Thanks.</issue_description>

<agent_instructions>make it Pimcore 12 and CoreShop 5 compatible, you can see the CoreShop studio implementation here coreshop/CoreShop#2942</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@dpfaffenbauer only composer package update, Pimcore 12 is pretty much the same as 11, except the license, where we haven't decided yet if still free or paid.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update pimcore-data-definitions to Pimcore 12 Update to Pimcore 12 and CoreShop 5 compatibility Jan 23, 2026
Copilot AI requested a review from dpfaffenbauer January 23, 2026 12:35
@dpfaffenbauer
Copy link
Collaborator

@copilot es ist besonders wichtig das der extjs Code von classic admin auf react für Studio umgebaut wird

Copy link
Author

Copilot AI commented Jan 23, 2026

@copilot es ist besonders wichtig das der extjs Code von classic admin auf react für Studio umgebaut wird

I understand - you need the ExtJS admin code converted to React for Pimcore Studio. I've analyzed the existing codebase (70 ExtJS files) and the CoreShop Studio implementation pattern from PR #2942.

This involves:

  • Creating a new Resources/assets/pimcore-studio directory with React/TypeScript structure
  • Setting up npm workspaces and rsbuild configuration
  • Converting all panels (import/export definitions), interpreters, setters, getters, providers, and import rules to React components
  • Using @pimcore/studio-ui-bundle as the UI foundation

I'll start implementing the React-based Studio UI following the CoreShop pattern.

@dpfaffenbauer
Copy link
Collaborator

@copilot move package json and build file in the root folder

Copy link
Author

Copilot AI commented Jan 23, 2026

@copilot move package json and build file in the root folder

Done in commit 53a10f1. Moved package.json, rsbuild.config.ts, and tsconfig.json to the repository root folder. Updated paths to point to the correct source locations.

@dpfaffenbauer
Copy link
Collaborator

@copilot also adapt docker-compose and other configs to work with pimcore generic data index and mercure

Copy link
Author

Copilot AI commented Jan 23, 2026

@copilot also adapt docker-compose and other configs to work with pimcore generic data index and mercure

Done in commit bf4af9f. Added Docker configuration with:

  • docker-compose.yaml.dist - PHP, Nginx, MySQL, OpenSearch (for Generic Data Index), and Mercure (for SSE)
  • .docker/nginx.conf - Mercure Hub proxy configuration
  • .docker/supervisord.conf - Messenger queue worker for index queues
  • Dockerfile - Development PHP image with xdebug
  • config/packages/pimcore_studio_backend.yaml - Mercure settings
  • config/packages/pimcore_generic_data_index.yaml - OpenSearch connection
  • Updated .env with OpenSearch and Mercure environment variables

@dpfaffenbauer
Copy link
Collaborator

@copilot ergänze noch die actions das der build bei jedem push gemacht wird und eingecheckt wird

Copy link
Author

Copilot AI commented Jan 23, 2026

@copilot ergänze noch die actions das der build bei jedem push gemacht wird und eingecheckt wird

Done in commit 7f07cc9. Added .github/workflows/frontend-build.yaml that:

  • Runs on every push/PR to 5.0 branch
  • Installs npm dependencies, runs lint and type check
  • Builds the Studio bundle with npm run build
  • Commits and pushes the built assets back to the repository

Also removed the Studio build output path from .gitignore so the assets are tracked in git.

@github-actions
Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (dpfaffenbauer)[https://github.com/dpfaffenbauer]
❌ @Copilot
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@dpfaffenbauer
Copy link
Collaborator

@aarongerig please approve license change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to Pimcore 12

2 participants