♿ Partial accessibility support #298
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances MenuOption and MenuTrigger components with accessibility properties to improve screen reader and assistive technology support. Adds accessible, accessibilityRole, and accessibilityLabel props that are properly forwarded to the underlying touchable components, ensuring better compliance with accessibility standards.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances accessibility support for the
MenuTriggerandMenuOptioncomponents by introducing new accessibility-related props and ensuring these props are passed down to the underlying elements. The changes improve the usability of these components for users relying on assistive technologies.Accessibility Enhancements:
Added new accessibility props: Introduced
accessible,accessibilityRole, andaccessibilityLabelprops to bothMenuTriggerandMenuOptioncomponents to support better accessibility. These props are now included in thepropTypesdefinitions.Updated destructuring and prop forwarding:
MenuTriggerandMenuOptionto include the new accessibility props.