Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple areas #6

Merged
merged 29 commits into from
Mar 18, 2024
Merged

Multiple areas #6

merged 29 commits into from
Mar 18, 2024

Conversation

cristianofmc
Copy link
Contributor

@cristianofmc cristianofmc commented Feb 6, 2024 •
edited
Loading

Code update for better discrimination of points of difference, separating each point of difference with its own rectangle.
image
image
image

  • rake spec
    image
  • rake rubocop
    image
  • rake rubocop:md
    image

cristiano-castro added 2 commits February 6, 2024 18:24
@cristianofmc cristianofmc self-assigned this Feb 6, 2024
@cristianofmc cristianofmc added the enhancement New feature or request label Feb 6, 2024
@cristianofmc cristianofmc linked an issue Feb 6, 2024 that may be closed by this pull request
Improve the visualization of differences #5
Closed
gsguma
gsguma reviewed Feb 8, 2024
View reviewed changes
spec/base_spec.rb Outdated Show resolved Hide resolved
gsguma
gsguma reviewed Feb 8, 2024
View reviewed changes
spec/base_spec.rb Outdated Show resolved Hide resolved
gsguma
gsguma previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@gsguma gsguma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 💯

@cristianofmc
Copy link
Contributor Author

image

@cristianofmc cristianofmc requested a review from gsguma February 9, 2024 22:15
gsguma
gsguma requested changes Feb 16, 2024
View reviewed changes
lib/image_compare/modes/base.rb Outdated Show resolved Hide resolved
lib/image_compare/modes/base.rb Outdated Show resolved Hide resolved
spec/base_spec.rb Outdated Show resolved Hide resolved
gsguma
gsguma requested changes Feb 16, 2024
View reviewed changes
spec/base_spec.rb Outdated Show resolved Hide resolved
@gsguma
Copy link
Contributor

gsguma commented Feb 16, 2024 •
edited
Loading

Don't forget to inspect code quality, running:

rake rubocop
rake rubocop:md

@cristianofmc cristianofmc requested a review from gsguma March 18, 2024 15:34
gsguma
gsguma previously approved these changes Mar 18, 2024
View reviewed changes
@cristianofmc cristianofmc merged commit 3a37184 into main Mar 18, 2024
1 check passed
@cristianofmc cristianofmc deleted the multiple_areas branch March 18, 2024 16:47
@gsguma gsguma restored the multiple_areas branch March 19, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsguma gsguma gsguma approved these changes

Assignees

@cristianofmc cristianofmc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the visualization of differences
2 participants
@cristianofmc @gsguma