RefExtract: Update eprint extraction in engine and regex #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleggm1
force-pushed
the
arxivurl_test
branch
3 times, most recently
from
aa4bff8 to
de51e2f
Compare
tsgit
suggested changes
Jul 29, 2019
refextract/references/regexs.py
Outdated
| [\s.-]*(?P<num>\d{4})(?!\d)(?:[\s-]*V(?P<version>\d))? | ||
| \s*(?P<suffix>\[[A-Z.-]+\])? """, re.VERBOSE | re.UNICODE | re.IGNORECASE) | ||
| \s*(?P<suffix>\[[A-Z.-]+\])? | ||
| (?:\.pdf)? """, re.VERBOSE | re.UNICODE | re.IGNORECASE) |
There was a problem hiding this comment.
this is non-sensical -- I wouldn't expect a .pdf after the category, the regexp is meant to match e.g. arxiv:1103.01234v5 [hep-th], which is a common way to refer to arXiv papers.
however I don't think
http://arxiv.org/pdf/arxiv:1103.01234v5 [hep-th].pdf is a thing to look for
refextract/references/engine.py
Outdated
|
|
||
| def arxiv_urls_to_report_numbers(citation_elements): | ||
| arxiv_url_prefix = 'http://arxiv.org/abs/' | ||
| arxiv_url_prefix = re.compile('^https?:\/\/(?:(?:cn\.|de\.|in\.|lanl\.)?arxiv\.org|xxx\.lanl\.gov)\/(?:abs|pdf)\/(\S+\d{4})(?:v\d)?(?:\.pdf)?', re.UNICODE | re.IGNORECASE) |
There was a problem hiding this comment.
version can be >9 e.g. v13. (?:v\d)? is not matching that
refextract/references/regexs.py
Outdated
| [\s.-]*(?P<num>\d{5})(?!\d) | ||
| (?:[\s-]*V(?P<version>\d))? | ||
| \s*(?P<suffix>\[[A-Z.-]+\])? | ||
| (?:\.pdf)? """, re.VERBOSE | re.UNICODE | re.IGNORECASE) |
refextract/references/regexs.py
Outdated
| (?:https?://(?:xxx\.)?lanl\.gov/(?:abs|pdf)/)| | ||
| (?:ARXIV[\s:-]*))(?P<year>(1[3-9]|[2-8][0-9]))-?(?P<month>(0[1-9]|1[0-2])) | ||
| [\s.-]*(?P<num>\d{5})(?!\d) | ||
| (?:[\s-]*V(?P<version>\d))? |
cleggm1
force-pushed
the
arxivurl_test
branch
from
00777cc to
bcdc081
Compare
Signed-off-by: Melissa Clegg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Melissa Clegg [email protected]