docextract: update report-numbers.kb #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds some CMS report numbers. Signed-off-by: fschwenn <[email protected]>
michamos
reviewed
Apr 25, 2019
| CMS PAS BTV ---CMS-PAS-BTV | ||
| CMS PAS FWD ---CMS-PAS-FWD | ||
| CMS PAS TRK ---CMS-PAS-TRK | ||
| CMS PAS SMP ---CMS-PAS-SMP |
There was a problem hiding this comment.
was this deleted on purpose?
There was a problem hiding this comment.
yes, it's a dup from line 265
|
LGTM |
tsgit
suggested changes
Apr 26, 2019
| CMS PAS DIF ---CMS-PAS-DIF | ||
| CMS PAS B2G ---CMS-PAS-B2G | ||
| CMS PAS LUM ---CMS-PAS-LUM | ||
| CMS PAS FTS ---CMS-PAS-FTA |
There was a problem hiding this comment.
is this correct, changing FTS to FTA ?
There was a problem hiding this comment.
I note that neither CMS-PAS-FTA nor CMS-PAS-FTS do appear to be used. See http://cdsweb.cern.ch/collection/CMS%20Physics%20Analysis%20Summaries?ln=en&as=1
search for those report number prefixes turns up empty
|
closing this PR, superseded by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fschwenn [email protected]