dhcpv6: explicitly ignore options that cannot be parsed

Signed-off-by: Chris Koch <[email protected]>
insomniacslk · Feb 19, 2023 · ee037bd · ee037bd
1 parent 6773f0d
commit ee037bd
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/dhcpv6/options.go b/dhcpv6/options.go
@@ -158,7 +158,10 @@ func (o *Options) FromBytesWithParser(data []byte, optioner Optioner) error {
 
 		opt := optioner(code)
 		if opt == nil {
-			return fmt.Errorf("option code %d is invalid in this message", code)
+			// Most RFCs that define options say that options
+			// should be ignored in messages where they don't
+			// belong.
+			opt = &OptionGeneric{OptionCode: code}
 		}
 		if err := opt.FromBytes(optData); err != nil {
 			return err