Skip to content

Change .default_teal_bslib_theming from object to function#1722

Open
llrs-roche wants to merge 1 commit into
mainfrom
1721_bslib_onload
Open

Change .default_teal_bslib_theming from object to function#1722
llrs-roche wants to merge 1 commit into
mainfrom
1721_bslib_onload

Conversation

@llrs-roche

Copy link
Copy Markdown
Contributor

Pull Request

Fixes #1721

Changes .default_teal_bslib_theming to a function. This should make it easier to work and cleans up a bit about the default values if option is missing.

@github-actions

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/after.R                            59      21  64.41%   42-52, 64, 69, 77-79, 81-89, 100, 104-105
R/checkmate.R                        24       0  100.00%
R/decorators-helpers.R               59       1  98.31%   97
R/dummy_functions.R                  61       2  96.72%   54, 56
R/include_css_js.R                   11       0  100.00%
R/init.R                            136       0  100.00%
R/module_bookmark_manager.R          99      54  45.45%   78-133
R/module_data_summary.R             177       8  95.48%   40, 50, 205, 236-240
R/module_filter_data.R               64       0  100.00%
R/module_filter_manager.R           210       7  96.67%   119-120, 316, 343, 355, 362-363
R/module_nested_tabs.R              411      42  89.78%   120, 178-183, 211, 315-330, 350-354, 409, 527-530, 534-537, 541-544
R/module_session_info.R              18       0  100.00%
R/module_snapshot_manager.R         276       9  96.74%   315-319, 386, 389-391
R/module_source_code.R               69       0  100.00%
R/module_teal_lockfile.R            131      53  59.54%   45-57, 60-62, 76, 86-88, 100-102, 110-119, 122, 124, 126-127, 142-146, 161-162, 177-186
R/module_teal_reporter.R            122       9  92.62%   60, 77-78, 81, 98, 128, 142, 144, 158
R/module_teal.R                     304      26  91.45%   130, 179, 235, 265-285, 315-316
R/module_transform_data.R           164      25  84.76%   77-81, 85-89, 106, 112, 119-120, 134-138, 188, 273-277
R/module_validate_error.R            73       0  100.00%
R/modules.R                         345      50  85.51%   170-174, 229-232, 332, 339, 353, 472, 570-576, 706-712, 725-733, 748-763, 796, 808-816
R/reporter_previewer_module.R        41      12  70.73%   41, 45, 68-85
R/teal_data_module-eval_code.R       23       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 23       0  100.00%
R/teal_data_utils.R                  49       0  100.00%
R/teal_modifiers.R                   57       0  100.00%
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      48       2  95.83%   153-154
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   363     255  29.75%   68-73, 125, 133-162, 193-202, 212, 227-275, 300-575, 603-628, 683, 685-688, 707-721, 738-739, 750-767
R/utils.R                           290      48  83.45%   404-453, 541-550
R/validate_inputs.R                  57       0  100.00%
R/validations.R                      58       0  100.00%
R/zzz.R                              23       1  95.65%   25
TOTAL                              3926     625  84.08%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/utils.R        -1      -1  +0.29%
TOTAL            -1      -1  +0.02%

Results for commit: 8372e16

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files   32 suites   3m 5s ⏱️
469 tests 419 ✅ 50 💤 0 ❌
744 runs  690 ✅ 54 💤 0 ❌

Results for commit 8372e16.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $133.50$ $-6.74$ $0$ $0$ $0$ $0$

Results for commit 6cb1a1a

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Default teal.bs_theme freezes build-time bslib scss paths into sysdata (breaks prebuilt P3M/RSPM binaries)

1 participant