Adds support for tbl_split to table_with_settings

[averissimo]

Pull Request

• Part of Rename tm_gtsummary to tm_tbl_roche_summary teal.modules.general#999

Changes description

• Add support for tbl_split from gtsummary
• Allow for zip files to be used to download tables if they cannot be generated in single file

[github-actions]

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      12  86.21%   116-121, 151-156
R/get_dt_rows.R                  13       0  100.00%
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       20      20  0.00%    83-103
R/optionalInput.R               255      79  69.02%   190, 315-389, 402-409, 411-416, 434, 436, 501, 583-596
R/panel_group.R                  39      39  0.00%    50-136
R/plot_with_settings.R          310      16  94.84%   301-307, 329, 366, 375-376, 392, 580-581, 583, 585
R/standard_layout.R              52       4  92.31%   90-93
R/table_with_settings.R         231      53  77.06%   32-33, 51-55, 87-94, 115, 160-219
R/utils.R                         7       0  100.00%
R/verbatim_popup.R              104      35  66.35%   112-113, 115, 123-154
R/white_small_well.R              7       0  100.00%
TOTAL                          1197     258  78.45%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  -------
R/table_with_settings.R      +32     +29  -10.88%
TOTAL                        +32     +29  -1.90%

Results for commit: 406165a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   16 suites   2m 9s ⏱️
172 tests 172 ✅ 0 💤 0 ❌
400 runs  400 ✅ 0 💤 0 ❌

Results for commit 406165a.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
plot_with_settings_ui	💔	$56.16$	$+2.57$	$0$	$0$	$0$	$0$

Results for commit 7eb42f4

♻️ This comment has been updated with latest results.

[llrs-roche]

Saving tables to a file can become complicated. Quite a lot of hours have been spent on how to do so that they comply with different policies and preferences.

However, when exporting to .csv there are unmatched quotes sometimes (from gtsummary::gt_summary() via tm_gt_template()):

[llrs-roche]

This might be a bit silly but the splits are also used to remove some columns. It would be great if instead of a file6de06d6041ec_1.csv and a file6de06d6041ec_2.csv we would get a file name a bit more meaningful: the variable_level or such.

[averissimo]

I've tried by keeping original file name and adding the variable level when possible.

Check it out on 92270c2

[llrs-roche]

It didn't work, now files are file112361464645_1_1.csv or such. My guess is that the label is somehow dropped o missed.

[averissimo]

Let me check if there's unpushed code

[averissimo]

Now with better naming:

<original_name>_<variable_level>_<index>

The index is just in case to avoid repetitions, and _<variable_level> is hidden if it's not a string

[averissimo]

@llrs-roche humm, I'm trying to check it out, thanks for pointing to that PR.

[llrs-roche]

The problem with the quotes might have been how Excel dealt with it, but I'm not sure.

I checked again the pdfs and now they aren't displayed correctly: Long tables show a horizontal scroll bar that doesn't work:

In any case I don't think we need to merge this for the demo (but the detail about sensible file names will be appreciated).

[averissimo]

@llrs-roche All fixed and improved implementation of label usage