Skip to content

Fix attribute when converting factors in ChoicesFilterState#678

Closed
nissinbo wants to merge 1 commit into
insightsengineering:mainfrom
nissinbo:main
Closed

Fix attribute when converting factors in ChoicesFilterState#678
nissinbo wants to merge 1 commit into
insightsengineering:mainfrom
nissinbo:main

Conversation

@nissinbo

@nissinbo nissinbo commented Feb 23, 2026

Copy link
Copy Markdown

Fixes #611

droplevels() was applied to avoid displaying unused levels in the filter. This dropped the attributes.
As a workaround, this PR restores the attributes after applying droplevels(). Please let me know if you would prefer a different approach.

@github-actions

github-actions Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@nissinbo

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@osenan

osenan commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Hi @nissinbo thanks for your contribution. I was working on this issue and arrived to the same solution that yours. I've also added some unit tests to check this functionality. Therefore we will continue reviewing the other PR, but basically we reached the same fix!

@nissinbo

Copy link
Copy Markdown
Author

@osenan Thank you! This seems to be resolved by #679, so I will close this PR.

@nissinbo nissinbo closed this Feb 26, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing variable label for factor variables only

2 participants