-
-
Notifications
You must be signed in to change notification settings - Fork 12
📑 Refactor: Adds new teal_report, teal_card class and revamps reporter UI
#331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 230 commits
Commits
Show all changes
322 commits
Select commit
Hold shift + click to select a range
d58f4cc
[skip style] [skip vbump] Restyle files
github-actions[bot] 8cc6788
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] 2c85ee8
update Reporter documentation for ReportDocument
m7pr 30007bd
Merge branch 'redesign@main' of https://github.com/insightsengineerin…
m7pr c76d665
update ReportDocument documentation
m7pr 445b454
[skip style] [skip vbump] Restyle files
github-actions[bot] 682db6d
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] 69633cc
tests for ReportDocument
m7pr 8d9ed72
Merge branch 'redesign@main' of https://github.com/insightsengineerin…
m7pr 1fd15b0
[skip style] [skip vbump] Restyle files
github-actions[bot] 847750a
allow setting a template fun to be added to every ReportDocument card
m7pr 42d1547
Merge branch 'redesign@main' of https://github.com/insightsengineerin…
m7pr 2c4c0cb
fix reorder_cards for ReportDocument
m7pr ef89896
edit previewer modal
m7pr 106fa7f
add text button
m7pr 192136d
cleanup
m7pr 05d97ff
cleanup
m7pr f1cb160
bring back observser for loading the reporter
m7pr cd59203
prefixes
m7pr 166a21c
tidyup previewer and editor
gogonzo 285c015
WIP editor
gogonzo 501b5e9
remove add new card button
m7pr 6ed5301
set class to ReportDocument after editing
m7pr c22ccae
remove comments
m7pr a4876f6
change assrtion in edit_report_document
m7pr 4a6cda5
feat: modify the add to reporter button
vedhav 4456334
add empty text block button
m7pr 1b6e5a4
bring back cards sorting
m7pr 7c3752e
Update R/Reporter.R
m7pr 83c9293
fixes #317
gogonzo 5afc410
editor
gogonzo e557679
debounce content edition for character input
m7pr f2d55d1
remove sorting of cards
m7pr cba3d6a
increase debounce
m7pr 51165f1
remove comment
m7pr d5699de
Edit Functionality for the Report Previewer module (#312)
m7pr 76ecba6
[skip style] [skip vbump] Restyle files
github-actions[bot] a1c8a71
extend documentation and tests for report_document
m7pr 83207be
merge documentation cleanup and tests extension
m7pr 5a61f5a
[skip style] [skip vbump] Restyle files
github-actions[bot] c224c2f
merge cleanup
m7pr b689adb
Merge branch 'redesign@main' of https://github.com/insightsengineerin…
m7pr 336a3fe
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] e83b392
fix accordion panel:
gogonzo 76d8404
bring back cards sorting
m7pr 6bad2bb
[skip style] [skip vbump] Restyle files
github-actions[bot] e91cdf2
fix tests
m7pr 4f7a58f
[skip style] [skip vbump] Restyle files
github-actions[bot] 79fb6d9
documentation fixes
m7pr 5a13e83
Merge branch 'redesign@main' of https://github.com/insightsengineerin…
m7pr 57bd1f0
cleanup dependencies
m7pr eae6a0f
fix r cmd check documentation
m7pr 62c6378
shinytest2 tests for previewer
m7pr d0e5cce
[skip style] [skip vbump] Restyle files
github-actions[bot] c6986b4
missing prefixes
m7pr d854fbd
merge
m7pr 7f091a4
[skip style] [skip vbump] Restyle files
github-actions[bot] f15a511
use new card system for testing
m7pr a6315bc
add prefixes
m7pr 7c8469d
Merge branch 'redesign@main' of https://github.com/insightsengineerin…
m7pr 0df9765
[skip style] [skip vbump] Restyle files
github-actions[bot] 61e460d
Fixes 1-card problem in refactor (#325)
averissimo 564b5ce
Improves `ReportDocument` editor (#326)
averissimo ada0651
[skip style] [skip vbump] Restyle files
github-actions[bot] 4098f55
fix x and code_chunk
gogonzo b7bce2e
introduce teal_reportable (WIP)
gogonzo 7c413cc
roxy fixes
gogonzo 5b9d899
as.reportable:
gogonzo 1fd5ebe
small fix
gogonzo b73f1db
ReportDocument to doc
gogonzo 32072a6
teal_reportable -> teal_report
gogonzo 58a31fd
feat: simplify eval_code and part of consistent naming
averissimo 2f436f2
chore: last of consisent naming
averissimo f023f09
chore: rename as.reportable
averissimo 6946350
fix: c.doc should merge multiple docs with a flat result
averissimo 9707699
fix: download report works as expected
averissimo 8f1d2c1
Merge branch 'redesign@main' into teal_reportable
averissimo 6b74814
cleanup: remove print debug
averissimo 70511e8
fix: adding regression when adding multiple blocks
averissimo 996f9e4
Merge branch 'redesign@main' into teal_reportable
averissimo c8b5ff4
cleanup: remove print debug
averissimo 8b7cc7c
chore: rename R and test files for doc class
averissimo 73903de
chore: import tests from reportable branch
averissimo 33734ba
Merge branch 'redesign@main' into teal_reportable
averissimo fcabc9f
chore: fix linter errors
averissimo 1d32c4e
[skip style] [skip vbump] Restyle files
github-actions[bot] 43a1f13
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] 88915bf
Fixes tests in `ReporterCard` feature branch (#328)
averissimo 46b11e2
chore: remove code dispatch parameter in eval_code
averissimo 994251f
Merge branch 'redesign@main' into teal_reportable
averissimo 98ce221
remaining report_document -> doc
gogonzo 26a809e
feat: add title to report in ReportDocument and trim separator (#330)
averissimo 1adc0bf
docs: update site and add accessibility
averissimo 7bb1080
fix: only add title to blocks if title exists
averissimo e00ca50
chore: remove newlines in separator of cards/docs
averissimo 3debdbe
Merge branch 'redesign@main' into teal_reportable
averissimo 6eb4410
fix: minor issues with rename of report_document -> doc
averissimo 35c39d9
chore: add a default title for unnamed cards
averissimo 7af6f3c
Merge branch 'redesign@main' into teal_reportable
averissimo bccefb4
- include_echo to include_results
gogonzo 4870485
tests: reflect new block element with title
averissimo 7c70953
tests: reflect new block element with title
averissimo 4f10fa0
Merge branch 'redesign@main' into teal_reportable
averissimo c6dead1
remove code_output (#332)
gogonzo c0966a0
Support to override methods `to_rmd` `toHTML` and `ui/srv_editor_bloc…
averissimo eb5fcd2
fix: add title argument to test_card helpers and fix leftover fun name
averissimo 38cf94f
[skip style] [skip vbump] Restyle files
github-actions[bot] 8845870
chore: linter changes
averissimo b791939
chore: add remotes and missing verdepcheck
averissimo d4c9266
docs: add missing function to yaml
averissimo 6c4e8aa
fix: correct arg name and remove some code
averissimo 3a935fc
chore: update pre-commit
averissimo 3fd2873
chore: import class definition
averissimo ed3ed47
chore: move lifecycle to suggests
averissimo ba2521a
chore: remove import
averissimo 6907c2d
empty: trigger ci
averissimo d142964
Naming (#334)
m7pr 53d2b16
[skip style] [skip vbump] Restyle files
github-actions[bot] 93f8673
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] bd93e4f
chore: fix linter
averissimo 40f0a4a
chore: spelling fixes
averissimo 8764bfe
chore: spelling fixes
averissimo c9ba7f9
teal_report class vignette
m7pr e9052f9
Merge branch 'teal_reportable' of https://github.com/insightsengineer…
m7pr 6d38378
chore: rcmdcheck with 0 erros and warnings
averissimo b7c4623
feat: support DT output
averissimo 78bcf29
cleanup: shinytest2 tests
averissimo 37516bf
fix: warning message on AppDriver creation
averissimo 508d79b
chore: clean tests that are not implemented
averissimo baf9700
remove edit_teal_card and keep_in_report
gogonzo 1cf0fc9
fix pkgdown
gogonzo 95cbdd3
feat: move keep_output to eval_code.teal_report
averissimo 560d815
chore: remove keep_output logical support
averissimo 69c8caa
docs: add eval_code method documentation for new parameters
averissimo 3b01d8c
chunks produce outputs which are excluded for rmd (#337)
gogonzo 26fda50
Merge branch 'teal_reportable' of https://github.com/insightsengineer…
m7pr b2aebd2
[skip style] [skip vbump] Restyle files
github-actions[bot] 37a7bf8
extend toHTML methods
m7pr a73eede
[skip style] [skip vbump] Restyle files
github-actions[bot] 99a6612
cleanup vignette - remove teal-report-class.Rmd
m7pr 7498b6c
to_rmd method for summary.lm
m7pr 3baf8fb
preserve metadata of the first element when combining teal_card objects
m7pr 0994baf
chore: revert back to main branch in description
averissimo 77d2d2a
revert current metadata preserving
m7pr eb9dee9
very provisional WIP
gogonzo d677b84
Fix tests in reportable branch and renames file (#341)
averissimo b3adb0b
Update tests/testthat/helper-waldo_compare.R
averissimo 00ed56c
Merge metadata of teal cards in `c.teal_card` (#342)
averissimo dc7e795
fix pkgdown build (#343)
m7pr da1e318
c.teal_report method (#338)
m7pr 2b4f8de
fix pkgdown
m7pr 0a90326
Fix `c.teal_card` to append only new element (#345)
gogonzo 71c4110
Use evaluate (#344)
gogonzo 3eeb473
fix: empty title
averissimo 63b17ea
fix: s4 cannot be of class chunk_output
averissimo 19d4524
Add seamless conversion of `teal_data` to `teal_report` object (#346)
averissimo 5853596
[skip style] [skip vbump] Restyle files
github-actions[bot] 063c636
fix reset
gogonzo 74c8023
`to_flextable` handles empty data.frames (#349)
m7pr 9059987
Exclude conditions (#350)
gogonzo e10fd20
fix: load functionality of reporter
averissimo 68c8abf
fix: typo on assignment of `%||%` before 4.4
averissimo bfbd49f
tests: missing template testing
averissimo 09a89fb
[skip style] [skip vbump] Restyle files
github-actions[bot] a74a916
fix: typo on method dispatch
averissimo c820dc0
Remove `ContentBlock` from `ReportCard` (#351)
averissimo 0e22756
feat: only header is draggable
averissimo 9bad3fa
feat: wrong option was commited, reverting to correct
averissimo cb51eda
fix: typo on render
averissimo 7f40a0d
fix: bookmark
averissimo 1720401
feat: support direct assignment
averissimo 2fe8ec2
fix: detect code chunks in teal_card
averissimo 5d7fc8d
fix: smaller fixes to tests and styler
averissimo a9e97cd
chore: more precise ignore of attributes
averissimo 0400956
[skip style] [skip vbump] Restyle files
github-actions[bot] 92b2441
fix: remove left padding in code element when inside pre
averissimo a669a29
Supports `gtsummary` outputs (#355)
averissimo faf72c4
Use teal card internally in `teal_reportable` feature branch (#353)
averissimo 58283de
Implement conversion of `ggplot` → `recordedplot` to save space in Re…
averissimo 514400c
Merge remote-tracking branch 'origin/main' into merge@teal_reportable
averissimo 4c78233
feat: previewer merged
averissimo 09b94b6
feat: more reorganizations and prevent modal card to be initalized mu…
averissimo 2241924
fix: cached objects
averissimo 4fae8e1
fix: minor cleanup of todos
averissimo 379b6dd
chore: remove unused code
averissimo 2f77185
[skip style] [skip vbump] Restyle files
github-actions[bot] a4856ef
docs: update documentation
averissimo 65e4d24
docs: test not using collate
averissimo 2390727
chore: fix lintr
averissimo 02ac937
chore: minor formatting
averissimo fbe1638
feat: disable add card button
averissimo 1e43b04
tests: minor fix to tests
averissimo df35258
docs: update documentation
averissimo bd4aedd
docs: test not using collate
averissimo 8d0cff3
[skip style] [skip vbump] Restyle files
github-actions[bot] bb79a52
feat: improvement on coercion to teal_report
averissimo 4025f54
Merge branch 'merge@teal_reportable' into teal_reportable
averissimo 494184b
chore: remove extra line
averissimo 2b78601
fix: remove empty lines
averissimo d4de3f1
missing imports in NAMESAPCE
m7pr 77f9fb1
chore: import teal_data class in roxygen2
averissimo fdac6c0
[skip style] [skip vbump] Restyle files
github-actions[bot] fd3cb92
chore: fix R CMD checks errors
averissimo c69249e
chore: re-add htmltools to dependencies
averissimo 7595b55
chore: rename
averissimo 56d2389
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] aa2c207
refactor: Render images to a folder when exporting the reporter (#384)
averissimo 1c4b26c
[skip style] [skip vbump] Restyle files
github-actions[bot] 75c73f3
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] ceb35a2
Apply suggestions from code review
m7pr 0919321
Update R/teal_card.R
m7pr d3eafad
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] a6dfced
Use basename in `.content_to_rmd` for Windows paths (#385)
m7pr 499505b
357 proper header for downloaded report (#389)
m7pr dbcd438
asserts for code_chunk named parameters
m7pr 28b4824
[skip style] [skip vbump] Restyle files
github-actions[bot] 1d7427c
Extend `shinyjs` to allow title edits in reporter previewer (#392)
m7pr de625e0
Update R/download.R
averissimo 63b8bef
Update R/previewer_card.R
averissimo f3267b5
Update R/teal_card.R
averissimo fd06a4b
chore: todo now has an issue in github
averissimo f0b5456
deprecate: Reporter()
averissimo 96ee9a6
chore: fix todo in tests
averissimo 0a01cde
fix: last todos in code and tests
averissimo 80c4c15
[skip style] [skip vbump] Restyle files
github-actions[bot] 2598149
fix 2 test
m7pr 450fa73
suppress deprecation
m7pr 33a59f7
fix 2 test
m7pr fdc3bf4
suppress deprecation
m7pr 2443501
fix: tests in Reporter
averissimo 2856846
fix: prevent conversion of ggplot2 to recordedplot
averissimo b5c6006
refactor: adds custom plot sizes for figures in previewer & reporter …
averissimo 6791d87
[skip style] [skip vbump] Restyle files
github-actions[bot] b914ea4
fix: test error with missing objects
averissimo 4d84637
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] c94d9a2
fix: problem with PR merge
averissimo 9e22b4f
387 Only show loading placeholder for cards that are being initialize…
m7pr 9428e1e
[skip style] [skip vbump] Restyle files
github-actions[bot] b729a3e
chore: fix linter
averissimo 564fd5f
chore: fix spelling
averissimo c069466
chore: adds missing verdepcheck
averissimo 2d6998d
docs: update NEWS.md
averissimo af5f5d6
chore: uses simpler api
averissimo 03aedc6
chore: add jsonlite and promote lifecycle to top-level
averissimo 2fce65b
chore: improve on deprecation messags
averissimo db8c9fe
chore: spelling
averissimo 91f621c
chore: update precommit
averissimo af43e5b
chore: fix nolint
averissimo 386ef9c
chore: remove chromote
averissimo 656c502
fix: add jsonlite to dummy
averissimo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| linters: linters_with_defaults( | ||
| line_length_linter = line_length_linter(120), | ||
| cyclocomp_linter = NULL, | ||
| object_usage_linter = NULL, | ||
| indentation_linter = NULL | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.