Skip to content

Fixes bug when label of dataset is a list#97

Merged
llrs-roche merged 4 commits into
mainfrom
fix_label
Jul 14, 2026
Merged

Fixes bug when label of dataset is a list#97
llrs-roche merged 4 commits into
mainfrom
fix_label

Conversation

@averissimo

Copy link
Copy Markdown
Contributor

@averissimo averissimo requested a review from osenan July 10, 2026 12:29
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  --------------------------------------------------------------
R/as_picks.R                140      21  85.00%   64, 168-172, 183-187, 202-208, 230-232
R/assertion.R                 5       0  100.00%
R/call_utils.R              147      22  85.03%   23-28, 65, 132-138, 261, 281-282, 285-289, 294
R/helpers.R                   9       0  100.00%
R/interaction.R              42       1  97.62%   105
R/module_merge.R            257       2  99.22%   328, 609
R/module_picks.R            324      23  92.90%   76-82, 101, 138-139, 328-330, 332-336, 474, 522, 560, 572, 580
R/picks.R                   191       1  99.48%   353
R/print.R                    36       2  94.44%   50, 58
R/resolver.R                148      15  89.86%   110-118, 291-296
R/tidyselect-helpers.R       29       0  100.00%
R/tm_merge.R                 54       0  100.00%
R/ui_containers.R            57       0  100.00%
R/zzz.R                       5       5  0.00%    3-11
TOTAL                      1444      92  93.63%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/resolver.R       +7       0  +0.50%
TOTAL              +7       0  +0.03%

Results for commit: 56b9080

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files   11 suites   19s ⏱️
278 tests 264 ✅ 14 💤 0 ❌
412 runs  397 ✅ 15 💤 0 ❌

Results for commit 56b9080.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_picks 👶 $+0.04$ picks_srv_resolves_datasets_that_has_a_named_list_label

Results for commit 4c04275

♻️ This comment has been updated with latest results.

@llrs-roche llrs-roche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment to avoid a warning for partial matching

Comment thread R/resolver.R Outdated
@llrs-roche llrs-roche self-assigned this Jul 10, 2026
@llrs-roche llrs-roche merged commit ac9ac64 into main Jul 14, 2026
6 of 20 checks passed
@llrs-roche llrs-roche deleted the fix_label branch July 14, 2026 13:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Crash when dataset has non-character label

2 participants