-
-
Notifications
You must be signed in to change notification settings - Fork 2
Add picks variable selection to ae_oview module #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 32 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
060314d
feat: add S3 method dispatch for picks or teal transform variables
975ae0a
tests: add test for tm_g_ae_oview module
b6fd8f6
chore: fix spelling
d68f94a
chore: fix sign credentials
osenan 3dd972e
[skip style] [skip vbump] Restyle files
github-actions[bot] 89ecbea
Update DESCRIPTION
osenan 630f5bf
Update R/tm_g_ae_oview_picks.R
osenan 2869ce9
Update R/tm_g_ae_oview_picks.R
osenan c2f07a3
Update R/tm_g_ae_oview_picks.R
osenan bf70fff
chore: update docs after fix style
osenan 88fbf7e
chore: fix typo in description
osenan 8bd9bd3
refactor: change defaults on ae_oview generic and use dataname directly
osenan 584c88b
refactor: add only necessary arguments to the UI
osenan b3f3eb0
fix: update test after refactor on method
osenan e00faee
[skip style] [skip vbump] Restyle files
github-actions[bot] 440b9fe
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] 5abc2ca
chore: fix linters and examples
osenan df0f269
[skip style] [skip vbump] Restyle files
github-actions[bot] b7219f0
chore: fix R CMD check and lintr
osenan 640f80e
[skip style] [skip vbump] Restyle files
github-actions[bot] 6e6e222
chore: fix styler and linter
osenan 73c6f60
chore: revert to magrittr pipe
osenan 8ca1bc1
chore: remove pipe consistency linter as we need magrittr pipes
osenan 0e4d1bc
Update R/tm_g_ae_oview.R
osenan af68495
refactor: use as.picks to reuse picks srv and ui in choices_selected
osenan e5e9dad
chore: fix lintr comment to avoid automatic restyling
osenan 5f0cfc2
Update R/tm_g_ae_oview_picks.R
osenan 0c0b079
refactor: simplify and avoid S3 method dispatch
osenan b91a4f7
chore: remove references to unused methods
osenan 756d9a4
chore: fix lintrs from CI
osenan ea0558b
refactor: avoid using parent envirionment and simplify conversion
osenan 1678829
Update R/tm_g_ae_oview.R
osenan af27484
Update R/utils.R
osenan bce4924
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] 4c910e5
Merge branch 'redesign_extraction@main' into oriol_ae_oview_picks@main
osenan f79e49d
chore: simplify DESCRIPTION and NAMESPACE
osenan e26de58
refactor: reuse functions from teal.modules.clinical for teal.transfo…
osenan d539dc1
chore: trigger CI on feature branch
osenan 8f19a12
chore: fix R CMD check
osenan e8572b5
[skip style] [skip vbump] Restyle files
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
teal.transform is in the Depends, and teal.picks is a substitute, so should also be in the Depends. the same we did in tmc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, changed