Skip to content

picks#942

Open
gogonzo wants to merge 194 commits into
mainfrom
redesign_extraction@main
Open

picks#942
gogonzo wants to merge 194 commits into
mainfrom
redesign_extraction@main

Conversation

@gogonzo

@gogonzo gogonzo commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Closes insightsengineering/NEST-roadmap#36

Check also with:

In this PR, due to the fact that data_extract_spec is not 1:1 convertible to picks, I propose to have an S3 method in each tm_ to switch between data_extract_spec/picks depending on the input type. Eventually, data_extract_spec variant will be removed completely after deprecation period.

Comment thread DESCRIPTION Outdated
Comment thread R/zzz.R
@llrs-roche llrs-roche added the core label Nov 3, 2025
@llrs-roche

Copy link
Copy Markdown
Contributor

Commenting here so we don't forget: tm_gtsummary will need to be added to this PR.

gogonzo added a commit to insightsengineering/teal that referenced this pull request May 19, 2026
Closes insightsengineering/NEST-roadmap#36

Check also with:
- insightsengineering/teal.transform#270
- insightsengineering/teal.modules.general#942

Introduces `validate_input` as an alternative to `shinyvalidate`
package. Function is easier to handle than `shinyvalidate`, as one can
use `validate_input()` in `reactive` and display-validation-error on the
input and throw shiny-validate-error in the same time. See tmg PR to see
how it works

---------

Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Co-authored-by: m7pr <marcin.kosinski.mk1@roche.com>
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* origin/main: (78 commits)
  [skip actions] Bump version to 0.7.0.9000
  [skip vbump] Release 0.7.0 Preparation (#1003)
  [skip actions] Bump version to 0.6.0.9028
  Temporary remove `tm_gtsummary` module (#1001)
  [skip ci] Update WORDLIST
  [skip actions] Bump version to 0.6.0.9027
  rewrite scatterplotmatrix so it uses patchwork (#986)
  [skip actions] Bump version to 0.6.0.9026
  Fix #629: Replace deprecated ggplot2::aes_string() and rename sec_axis(trans=) to transform= (#998)
  [skip actions] Bump version to 0.6.0.9025
  Fix UI overlap in tm_g_distribution output panel (#896) (#997)
  [skip actions] Bump version to 0.6.0.9024
  Fix 'Show only distinct rows' in tm_data_table (#993)
  [skip actions] Bump version to 0.6.0.9023
  Report errors on the table creation to the user (#982)
  [skip actions] Bump version to 0.6.0.9022
  Use *_transform_teal_data on tm_gtsummary  (#994)
  [skip actions] Bump version to 0.6.0.9021
  Bring back tm_g_association tests since ggmosaic issue is resolved (#991)
  [skip actions] Bump version to 0.6.0.9020
  ...
@github-actions

Copy link
Copy Markdown
Contributor


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


2 out of 3 committers have signed the CLA.
✅ (gogonzo)[https://github.com/gogonzo]
✅ (vedhav)[https://github.com/vedhav]
@Dawid Kaledkowski
Dawid Kaledkowski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design data extract and data merge

5 participants