Implements teal.picks picks on tm_outliers - #1006
Merged
donyunardi merged 13 commits intoJul 30, 2026
Merged
Conversation
averissimo
marked this pull request as ready for review
July 22, 2026 07:28
averissimo
marked this pull request as draft
July 22, 2026 07:30
Contributor
Contributor
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit 07e29f4 ♻️ This comment has been updated with latest results. |
…raction@main Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
averissimo
marked this pull request as ready for review
July 29, 2026 13:11
…ightsengineering/teal.modules.general into tm_outliers@redesign_extraction@main * 'tm_outliers@redesign_extraction@main' of github.com:insightsengineering/teal.modules.general: fix: rename non-portable file fix: need to normalize to lists on method implementation Apply suggestion from @m7pr fix: deselecting api for teal.picks selection [skip style] [skip vbump] Restyle files [skip roxygen] [skip vbump] Roxygen Man Pages Auto Update fix: tm_g_distribution and linter docs: name cleanup and examples feat: update shinytest2 fix: tests with new S3 [skip roxygen] [skip vbump] Roxygen Man Pages Auto Update Restore `gt_summary` and allow for general usage (#1004) fix: linter errors
llrs-roche
reviewed
Jul 29, 2026
llrs-roche
left a comment
Contributor
There was a problem hiding this comment.
I like that now examples are much shorter. Nice work.
Just a few comments
Contributor
Author
|
@llrs-roche I think I addressed the comments from the previous review |
llrs-roche
approved these changes
Jul 30, 2026
llrs-roche
left a comment
Contributor
There was a problem hiding this comment.
Looks great. just one last additional comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request