Fixes 4 modules that had problems with migration to picks#1542
Open
averissimo wants to merge 11 commits into
Open
Fixes 4 modules that had problems with migration to picks#1542averissimo wants to merge 11 commits into
picks#1542averissimo wants to merge 11 commits into
Conversation
…into fix_mods@279-interactive_variables@main * origin/279-interactive_variables@main: remove skills simplify tm_t_binary_outcome (#1538) Fixes in modules and documentation after manual revision of module migration (#1536) Fix test@279 interactive variables@main (#1534) Unify module_argument template and documentation of arguments (#1532) Unify picks feature branch: default parameters (#1533)
Contributor
Author
|
Modules no longer use Note: different levels of changes were required for the 4 affected modules |
Contributor
Unit Tests Summary 1 files ± 0 74 suites ±0 2h 0m 9s ⏱️ + 6m 57s For more details on these failures and errors, see this check. Results for commit fa47a25. ± Comparison against base commit b681610. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit 3f884d1 ♻️ This comment has been updated with latest results. |
averissimo
changed the title
picks
…active_variables@main Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Contributor
Author
|
@osenan please review this PR :-) |
osenan
requested changes
Jun 30, 2026
osenan
left a comment
osenan
left a comment
Contributor
There was a problem hiding this comment.
Great job with the changes. That is a big step forward. I do not identify any error with the new validations. I tested two modules manually and they worked fine. With the changes in the validation and in the defaults tests should be updated. We have several e2e test failing. I also see that the description is not matching the expectation in some cases. Please fix that before merging, but the big step is already done.
Please also fix the other checks.
| need(length(anl_selectors$aval_var()$variables$selected) >= 1L, "An analysis variable is required") | ||
| validate_input( # delayed validation for responders until after choices are updated based on PARAMCD selection | ||
| inputId = "responders", | ||
| condition = !is.null(input$responders) && length(input$responders) > 0L, |
Contributor
There was a problem hiding this comment.
very good way to combine the aval_var and arm_var in something more informative for the user
| inputId = "conf_level", | ||
| condition = { | ||
| cv <- suppressWarnings(as.numeric(input$conf_level)) | ||
| !is.na(cv) && cv > 0 && cv < 1 |
Contributor
There was a problem hiding this comment.
like this it will not allow to put edge cases 0 and 1
| inputId = "conf_level", | ||
| condition = { | ||
| cv <- suppressWarnings(as.numeric(input$conf_level)) | ||
| !is.na(cv) && cv > 0 && cv < 1 |
Contributor
There was a problem hiding this comment.
Is not a big deal, as in other modules, here we do not accept anymore the edge cases of 0 and 1. But we do not have to change it
| plot_before <- app_driver$get_active_module_plot_output("patient_timeline_plot") | ||
| set_teal_picks_slot(app_driver, "aeterm", "variables", character(0L)) | ||
| testthat::expect_false(identical(plot_before, app_driver$get_active_module_plot_output("patient_timeline_plot"))) | ||
| app_driver$expect_validation_error() |
Contributor
There was a problem hiding this comment.
why there is a validation error? According to the test title it should not be
| plot_before <- app_driver$get_active_module_plot_output("patient_timeline_plot") | ||
| set_teal_picks_slot(app_driver, "cmdecod", "variables", character(0L)) | ||
| testthat::expect_false(identical(plot_before, app_driver$get_active_module_plot_output("patient_timeline_plot"))) | ||
| app_driver$expect_validation_error() |
Contributor
There was a problem hiding this comment.
previously we were not expecting validation error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
WIP to fix
iv_rusage and other problems detected on manual review.Changes description
arm_ref_comp_buckets_validatortm_t_binary_outcometm_g_citm_t_coxregtm_t_glm_counts