898 save app state version 3#1105
Draft
chlebowa wants to merge 31 commits into
Draft
Conversation
16 tasks
chlebowa
marked this pull request as ready for review
March 15, 2024 15:08
Contributor
Unit Tests Summary 1 files 33 suites 2s ⏱️ Results for commit 19cca0a. ♻️ This comment has been updated with latest results. |
added 5 commits
March 27, 2024 14:05
…ring/teal.modules.clinical into 898_save_app_state3@main
Contributor
|
@donyunardi this one is paused as I noticed some restore issues - specifically "teal_bookmarkable" was not properly set for some modules (I don't remember which now), but it looked serious for me back then in March |
donyunardi
marked this pull request as draft
May 13, 2024 15:57
Contributor
|
@donyunardi @gogonzo seems like this is an abandoned PR, should we revisit it close? |
Contributor
I don't think it is a good moment to start this. I would wait to the moment when we refactor these modules. PR will most probably be closed. For now it can stay open just to have a good example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to insightsengineering/teal#1011
Replaces uses of
update*Inputwith server-side input creation withrenderUI.