ETCM-6659 allow unset permissioned candidates if P=0 #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGLO
reviewed
Apr 4, 2025
toolkit/committee-selection/authority-selection-inherents/src/tests.rs
Outdated
Show resolved
Hide resolved
LGLO
reviewed
Apr 4, 2025
toolkit/committee-selection/authority-selection-inherents/src/authority_selection_inputs.rs
Outdated
Show resolved
Hide resolved
|
I'm afraid that #638 is better, because it makes the change local to data source and doesn't break things. All the knowledge needed for the case we want to support in this PR description is available in data source. |
kpinter-iohk
force-pushed
the
ETCM-6659-allow-unset-permissioned-candidates-2
branch
3 times, most recently
from
566f50d to
6d628f0
Compare
kpinter-iohk
force-pushed
the
ETCM-6659-allow-unset-permissioned-candidates-2
branch
from
6d628f0 to
d950c20
Compare
kpinter-iohk
force-pushed
the
ETCM-6659-allow-unset-permissioned-candidates-2
branch
from
d950c20 to
da08d88
Compare
LGLO
reviewed
Apr 8, 2025
LGLO
reviewed
Apr 8, 2025
toolkit/data-sources/db-sync/testdata/migrations/6_insert_transactions.sql
Show resolved
Hide resolved
LGLO
reviewed
Apr 8, 2025
toolkit/committee-selection/authority-selection-inherents/src/ariadne_inherent_data_provider.rs
Outdated
Show resolved
Hide resolved
LGLO
approved these changes
Apr 8, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚨 This PR is similar to #638 but it moves the logic out of the data source layer.
When getting Ariadne parameters, if num_permissioned_candidates in d_params is 0, having not inserted a permissioned candidates list is not an error. If a chain does not wish to have any permissioned candidates, this way they won't need to spend ADA submitting an empty list of them.
Checklist
changelog.mdfor affected crate