Skip to content

Fix issues in quirks.nix #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issues in quirks.nix #219

wants to merge 1 commit into from

Conversation

andreabedini
Copy link
Member

If GITHUB_ACTIONS is not defined the check "$GITHUB_ACTIONS" = "true"
might fail. The CODESPACES variable is always set to "true" in GitHub
Codespaces so we can use the same mechanism there.

@andreabedini andreabedini marked this pull request as draft July 18, 2025 05:45
If GITHUB_ACTIONS is not defined the check "$GITHUB_ACTIONS" = "true"
might fail. The CODESPACES variable is always set to "true" in GitHub
Codespaces so we can use the same mechanism there.
@andreabedini andreabedini marked this pull request as ready for review July 18, 2025 05:48
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, however as we lost our Mac's for the next 4wks. I'm not sure we should merge this right now 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants