Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove offscreen items when idle #523

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove offscreen items when idle #523

wants to merge 1 commit into from

Conversation

inokawa
Copy link
Owner

@inokawa inokawa commented Oct 13, 2024 •
edited
Loading

This PR will change overscan behavior while not scrolling, from rendering overscaned items(like react-window, #273 (comment)) to not rendering them.

Benefits:

  • Fewer items cost less to render.
  • This change will solve the problem that remount of items on the opposite side of scrolling can cause small glitch sometimes at the bottom end of scroll area.

@m-a-r-c-e-l-i-n-o

This comment was marked as off-topic.

Sign in to view
@inokawa
Copy link
Owner Author

inokawa commented Nov 23, 2024

@m-a-r-c-e-l-i-n-o
I think it's not related to this. Please make an issue with a reproduction.

@inokawa inokawa force-pushed the main branch 3 times, most recently from e26ecfb to 12af5e5 Compare December 5, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inokawa @m-a-r-c-e-l-i-n-o