Improved DataExtractor class #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit solves a bug in the DataExtractor class and improves its performance in some corner cases. Before this commit, the DataExtractor class failed if a variable had a dimension 1 on an axis with index i if there was an axis with index j of dimension > 1 such that j < i. This should be fixed with this commit. Moreover, it cleans a little bit the code making some statements more readable. Finally, it also improves the performance of the classes when we read the first layer of a 3D variable (i.e., when we submit the argument dimvar=2). Before, it read all the variable and then it discarded all the layers different from 0. Now the routine reads only the required data.
spiani
force-pushed
the
improve_dataextractor
branch
from
d373a61 to
4605c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit solves a bug in the DataExtractor class and improves its performances for some corner cases.
Before this commit, the DataExtractor class failed if a variable had a dimension 1 on an axis with index i and if there was an axis with index j of dimension > 1 such that j < i. This should be fixed with this commit.
Moreover, it cleans a little bit the code making some statements more readable.
Finally, it also improves the performance of the classes when we read the first layer of a 3D variable (i.e., when we submit the argument dimvar=2). Before, it read all the variable and then it discarded all the layers different from 0. Now the routine reads only the required data.