Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative header paths instead of absolute paths #30

Closed
wants to merge 2 commits into from

Conversation

rockerbacon
Copy link

Description

Use relative paths when including internal header files.

As an added bonus I changed some test literals to clean up warnings when building the tests.

Why?

By using relative paths the library will work anywhere it might be copied to, without the need for extra build configurations.

I ran into a problem when importing this library in my benchmark project because the dependency manager tool I'm using moves the include files to a subfolder inside a fixed include directory (the subfolder is there to avoid name collisions).

@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #30 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files           5        5           
  Lines         138      138           
=======================================
  Hits          130      130           
  Misses          8        8           
Impacted Files Coverage Δ
include/thread_pool/thread_pool.hpp 95.23% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af95dd8...24ae2e6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant