Check for blank choices

inkle · Jan 30, 2018 · 4718d07 · 4718d07
1 parent c10d2df
commit 4718d07
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/inklecate/InkParser/InkParser_Choices.cs b/inklecate/InkParser/InkParser_Choices.cs
@@ -84,6 +84,10 @@ protected Choice Choice()
             if (emptyContent && diverts == null)
                 Warning ("Choice is completely empty. Interpretting as a default fallback choice. Add a divert arrow to remove this warning: * ->");
 
+            // * [] some text
+            else if (!startContent && hasWeaveStyleInlineBrackets && !optionOnlyContent)
+                Warning ("Blank choice - if you intended a default fallback choice, use the `* ->` syntax");
+
             if (!innerContent) innerContent = new ContentList ();
 
             var tags = Parse (Tags);

diff --git a/tests/Tests.cs b/tests/Tests.cs
@@ -2893,13 +2893,24 @@ public void TestVariousDefaultChoices ()
 * ->
    - - 2
 - 3
-* [] ->
-- 4
 -> END
 ";
 
             var story = CompileString (storyStr);
-            Assert.AreEqual ("1\n2\n3\n4\n", story.ContinueMaximally ());
+            Assert.AreEqual ("1\n2\n3\n", story.ContinueMaximally ());
+        }
+
+
+        [Test ()]
+        public void TestVariousBlankChoiceWarning ()
+        {
+        	var storyStr =
+        @"
+* [] blank
+        ";
+
+        	CompileString (storyStr, testingErrors:true);
+            Assert.IsTrue (HadWarning ("Blank choice"));
         }
 
         [Test ()]