Serialize live integration test files - #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive Summary
Run live integration test files sequentially to prevent overlapping checks against the same agent.
0.2.12, synchronize the lockfile version, and update the changelog.Description
Set
fileParallelism: falseinvitest.live.config.ts. The email and SMS test files use shared agent fixtures, so running one file at a time prevents their requests and cleanup hooks from overlapping.Reason
Concurrent channel checks can interfere with each other when they share an agent session. Serial execution lets each file finish its reply checks and cleanup before the next begins.
Decisions
Testing
npm test: all 891 tests passed across 74 files.npm run lint,npm run typecheck, andnpm run build: passed.uv run --no-project python -m unittest tests/live/test_a2a_preflight.py: all four tests passed.fileParallelism === falseandmaxWorkers === 1; both checks passed.npx vitest run --config vitest.live.config.ts tests/live/email-reply.test.ts tests/live/sms.test.tswith both live credentials unset: both files loaded and all four live tests skipped as expected. Actual email/SMS delivery was not exercised locally.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.