Skip to content

fix(adapter): prevent dictionary memory leak and runtime dict iterati… #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adityakk9031 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(adapter): prevent dictionary memory leak and runtime dict iterati… #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2658,10 +2658,19 @@ async def send(
# post-call send_message tool call is exactly the case that bit us
# (the agent's "reflect on the call" reply leaked out as an email).
VOICE_GRACE_SECONDS = 60
now = time.time()
# Garbage-collect all stale entries across chats so the dictionary doesn't grow unbounded.
stale_chats = [
cid for cid, ts in list(self._voice_recently_closed.items())
if (now - ts) > VOICE_GRACE_SECONDS
]
for cid in stale_chats:
self._voice_recently_closed.pop(cid, None)

closed_at = self._voice_recently_closed.get(str(chat_id))
if (
closed_at is not None
and (time.time() - closed_at) < VOICE_GRACE_SECONDS
and (now - closed_at) < VOICE_GRACE_SECONDS
and chat_id not in self._active_call_ws
and not self._last_inbound_modality.get(str(chat_id))
):
Expand All @@ -2670,9 +2679,6 @@ async def send(
chat_id, (content or "")[:60].replace("\n", " "),
)
return SendResult(success=True, message_id="suppressed-post-call-leak")
# Garbage-collect stale entries so the dict doesn't grow unbounded.
if closed_at is not None and (time.time() - closed_at) > VOICE_GRACE_SECONDS:
self._voice_recently_closed.pop(str(chat_id), None)

# Resolve mode if the gateway didn't pass one explicitly. Order of
# preference:
Expand Down
Loading