Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split operator vesting #7

Merged
merged 15 commits into from
Mar 18, 2024
Merged

feat: split operator vesting #7

merged 15 commits into from
Mar 18, 2024

Conversation

JSHan94
Copy link
Contributor

@JSHan94 JSHan94 commented Mar 13, 2024

  • split modules
    • vip_reward: reward store for user & operator
    • vip_vault: vip reward vault
    • vip_operator: operator store for commission
    • vip_vesting: vesting store for user & operator. vest reward,
    • vip_zapping: handle zapping
    • vip: operate vip as policy

Summary by CodeRabbit

  • New Features
    • Added functionality for managing vesting for users and operators in a VIP system.

@JSHan94 JSHan94 requested review from ALPAC-4 and beer-1 March 13, 2024 04:19
@JSHan94 JSHan94 requested a review from a team as a code owner March 13, 2024 04:19
Copy link

coderabbitai bot commented Mar 13, 2024

Walkthrough

The changes encompass expanding functionality within the VIP system to include managing vesting, vault systems, and scoring mechanisms, enhancing the overall VIP ecosystem.

Changes

File Summary
precompile/modules/initia_stdlib/sources/vip/vesting.move
precompile/modules/initia_stdlib/sources/vip/vault.move
Introduces functionality for managing vesting in a VIP system, including structures, events, and functions for users and operators. Additionally, introduces a vault system with features for managing rewards, deposits, and balances.
precompile/modules/minitia_stdlib/sources/vip/score.move Updates in the minitia_std::vip_score module include changes to the ModuleStore struct and the introduction of new events.

Poem

Among the code's intricate wolds,
Vesting and vaults their tales unfold.
Scores updated, events proclaim,
In the VIP realm, they etch their name.
🐇✨📜

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JSHan94 JSHan94 merged commit 14b2b7e into main Mar 18, 2024
1 check passed
@JSHan94 JSHan94 deleted the vip/operator branch March 18, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants