Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split compiler #15

Merged
merged 7 commits into from
Mar 20, 2024
Merged

feat: split compiler #15

merged 7 commits into from
Mar 20, 2024

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Mar 20, 2024

cargo dependency resolver treat features as addictive way, so when we build compiler with vm then it enable "testing" feature for all move packages including movevm.

To solve this problem, we need to split the complier from our runtime.

Summary by CodeRabbit

  • New Features

    • Introduced functionality for interacting with a compiler for a specific language.
    • Streamlined and updated compiler-related files and structures.
    • Added compiler interaction options for building, testing, documentation, proving, and analyzing coverage.
    • Restructured the API surface for managing Move packages within the MoveVM.
    • Enhanced error handling and memory management functionalities.
  • Bug Fixes

    • Fixed exclusion rule for **/artifacts/ directory in .gitignore.
  • Documentation

    • Updated comments and documentation for clarity and usage instructions.

@beer-1 beer-1 requested a review from a team as a code owner March 20, 2024 06:47
@beer-1 beer-1 self-assigned this Mar 20, 2024
Copy link

coderabbitai bot commented Mar 20, 2024

Walkthrough

The changes encompass a comprehensive overhaul in compiler interaction, API restructuring, and build process enhancements across various files. These modifications streamline code, introduce compiler-specific bindings, and bolster error handling in api, libcompiler, and libmovevm directories. The goal is to enhance compilation, testing, and documentation generation workflows.

Changes

File(s) Change Summary
.github/workflows/build.yml, Makefile Added libcompiler to workflow triggers and shared libraries, updated build steps.
.gitignore Excluded **/artifacts/ directory.
api/bindings.h, libmovevm/bindings.h Streamlined by removing redundant declarations related to compiler options.
api/bindings_compiler.h, libcompiler/bindings_compiler.h Introduced compiler-specific functionality and structures.
api/compiler.go Updated include directive to bindings_compiler.h.
builders/Dockerfile.* Adjusted working directories and build commands.
builders/guest/build_*.sh Enhanced build scripts for different architectures.
libcompiler/* Added compiler functionality, error handling, and tests.
libmovevm/* Restructured API surface and removed specific functions.
crates/natives/src/query.rs Optimized code by removing testing-related imports.

Poem

Amidst the code's intricate rhyme,
Compiler's melody beats in time.
Errors tamed, APIs refined,
A rabbit's joy, in code entwined. 🐇✨

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@Vritra4 Vritra4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit a4ca60f into main Mar 20, 2024
2 checks passed
@beer-1 beer-1 deleted the feat/split-compiler branch March 20, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants