feat: need to mark invalidate first to cover init_module failure

[beer-1]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Enhanced validation for the init_module function to require exactly one parameter, improving clarity and robustness in module initialization.

• Bug Fixes

  • Streamlined cache invalidation process in the InitiaVM implementation to eliminate redundancy and improve control flow.

[coderabbitai]

Walkthrough

The pull request introduces changes to the parameter validation logic for the init_module function across multiple files. The conditions now require exactly one parameter, enhancing the strictness of the validation process. These modifications improve the clarity and robustness of the code without altering any declarations of exported or public entities.

Changes

File	Change Summary
crates/compiler/src/extended_checks.rs	Updated ExtendedChecker to require exactly one parameter for init_module, enhancing validation.
crates/vm/src/verifier/module_init.rs	Modified verify_module_init_function to enforce exactly one parameter for init_module, tightening verification.

Poem

🐇 In the code where bunnies hop,
Parameters now must not flop!
One is the rule, no more, no less,
With clarity gained, we surely impress.
Hopping along, with newfound ease,
Our code now dances, just like the breeze! 🌟

Tip

Announcements

• The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
• We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
• Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dc8c8e2 and 1f9769b.

Files selected for processing (2)

• crates/compiler/src/extended_checks.rs (1 hunks)
• crates/vm/src/verifier/module_init.rs (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• crates/compiler/src/extended_checks.rs
• crates/vm/src/verifier/module_init.rs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c3788f3 and dc8c8e2.

Files selected for processing (3)

• crates/compiler/src/extended_checks.rs (1 hunks)
• crates/vm/src/initia_vm.rs (1 hunks)
• crates/vm/src/verifier/module_init.rs (1 hunks)

Additional comments not posted (1)

crates/vm/src/initia_vm.rs (1)

453-455: LGTM!

The repositioning of the mark_loader_cache_as_invalid() call and the associated comment is a good improvement. It ensures that the loader cache is invalidated at the earliest possible point in the process, before resolving any pending code publish requests.

This change eliminates the redundancy of executing the cache invalidation both before and after the resolve_pending_code_publish call, streamlining the logic and improving the clarity of the code.