Skip to content

[FIX] account_interests: change job_id for cron_id#849

Open
cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
adhoc-dev:18.0-t-60625-cav
Open

[FIX] account_interests: change job_id for cron_id#849
cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
adhoc-dev:18.0-t-60625-cav

Conversation

@cav-adhoc
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 15, 2025 17:38
@roboadhoc
Copy link
Contributor

Pull request status dashboard

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

El propósito de este PR es corregir la referencia al ID del cron en el contexto, cambiando de job_id a cron_id en el módulo account_interests. Este cambio es necesario para acceder correctamente al cron que está ejecutando la tarea.

Cambios clave:

  • Actualización de la referencia contextual de job_id a cron_id en el método _cron_recurring_interests_invoices
  • Mejoras de formato en múltiples líneas para cumplir con estándares de código

[
("next_date", "<=", current_date),
("bypass_company_interest", "=", True),
]
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En Odoo 19, el contexto de los crons utiliza cron_id en lugar de job_id. Este cambio es correcto y necesario. Sin embargo, asegúrate de que el bump de versión en __manifest__.py esté incluido en este PR, ya que se están modificando comportamientos de modelo.

Copilot generated this review using guidance from repository custom instructions.
move_line_domain += safe_eval.safe_eval(
self.domain, self._get_eval_context()
)

Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El mensaje de error 'Something went wrong' es demasiado genérico y poco informativo. Considera incluir más contexto, como el ID del partner o de la factura que falló, por ejemplo: f'Error al crear factura de intereses para partner {partner.id}: {e}'

Suggested change
_logger.error(f"Error al crear factura de intereses para partner {partner.id}: {e}")

Copilot uses AI. Check for mistakes.
@rov-adhoc
Copy link
Contributor

@roboadhoc r+

@roboadhoc
Copy link
Contributor

@cav-adhoc @rov-adhoc linked pull request(s) ingadhoc/product#833 not ready. Linked PRs are not staged until all of them are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants