Skip to content
This repository was archived by the owner on May 13, 2020. It is now read-only.

Conversation

@henriquelampert
Copy link

Issues #18 and #25

.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henriquelampert It's a good practice to always end a file with a blank new line

@barbolo
Copy link
Member

barbolo commented Feb 24, 2014

@henriquelampert I made several comments about changing "WEEK" to "WEEKLY" and "DAY" to "DAILY". I understood your position when choosing these words, so please ignore all my comments about that.

Finally, as we have talked, the subscriptions should be boolean and the day/week summary emails should both be sent.

rafaelivan added a commit that referenced this pull request Aug 28, 2014
This is the code from pull request #34 with very little refactory.
rafaelivan added a commit that referenced this pull request Aug 28, 2014
This is the code from pull request #34 with very little refactory.
rafaelivan added a commit that referenced this pull request Aug 28, 2014
This is the code from pull request #34 with very little refactory.
rafaelivan added a commit that referenced this pull request Aug 28, 2014
This is the code from pull request #34 with very little refactory.
rafaelivan added a commit that referenced this pull request Aug 28, 2014
This is the code from pull request #34 with very little refactory.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants