Feature/JA-80 UiMessagesService #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilure notifications
|
looks good, I'll approve this once we're done with services |
Except ValidationScriptsPartial
Also added missing calls to show messages and fixed minor issues found in code.
From notificationType to messageType.
Test - Ads_WhenResponseIsUnsuccessful_ShouldShowFailureMessage
Tests: - ShowMessage_WhenHttpContextIsNull_ShouldNotThrowException - ShowMessage_WhenMessageIsNull_ShouldReplaceItWithEmptyString - ShowMessage_WhenMessageTypeIsNull_ShouldReplaceItWithEmptyString - ShowMessage_WhenCalled_ShouldCorrectlyAddMessageToTempData - ShowSuccessMessage_WhenCalled_ShouldAddMessageWithCorrectType - ShowFailureMessage_WhenCalled_ShouldAddMessageWithCorrectType
Zjyslav
changed the title
|
I changed name of the service to I added some missing messages to be shown, but I didn't touch our Admin Panel controllers. I added tests for the service and 1 for |
GrzegorzKmiecinski
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's not what we're supposed to be focusing or right now, but I was a little inspired to make a centralized way of showing notifications.
I reduced out notifications to 2 types - Success and Failure. Message text is still added via TempData, but not directly.
To use this system, you inject
INotificationServiceand callShowSuccessNotification(string message)orShowFailureNotification(string message)on it.I also added a static class with
public const stringfields with names of partials and notification types, so if we want to add a new partial, I suggest we add its name to thePartialNamesclass and use it in Razor like this:<partial name="@PartialNames.MyPartial">. This way we reduce the number of hardcoded strings and keep them in a single location.