Feature/ja-25 add localization #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrzegorzKmiecinski
changed the title
…ion of other files
…nfoshareacademy/jcszr12-Jaszczur into feature/ja-25-add-locatization
GrzegorzKmiecinski
requested review from
Zjyslav and
skrawus
and removed request for
Zjyslav
Zjyslav
requested changes
Jul 5, 2024
There was a problem hiding this comment.
Overall great work, but I found some things to correct in English version:
-
Home/Index- link says "Your class dates", but the page it links to says "Your schedule" - I'd make it the latter in both cases. -
Home/Tutor: the header is not translated and first item on list of links is just "Add" - I'd change it to "Create ad" (on "New ad" to be consistent with what you see after clicking it) -
Browse/Ads- page number on the bottom is not translated -
Shared/Components/CreateRequestForAd- form labels are not translated - you need to replace@Html.DisplayNameForwith resource (and I think removeasp-forfrom label). -
Tutor/CreateScheduleItem- button is in Polish - I would change in Polish version
Funkcjonalność studentatoFunkcjonalność ucznia
Zjyslav
requested changes
Jul 5, 2024
There're no conflicts in the VS but GH shows it's something with blazor. @Zjyslav can you take a look?
|
Whole |
Zjyslav
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.