Conversation
romac
reviewed
Jun 27, 2025
| @@ -0,0 +1,4 @@ | |||
| *May 27th, 2025* | |||
Contributor
There was a problem hiding this comment.
This should be today's date, right?
romac
reviewed
Jun 27, 2025
| - uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| toolchain: 1.85.0 |
Contributor
There was a problem hiding this comment.
Might be best to use rust-toolchain.toml file to avoid having to manually update all workflows, then we can remove toolchain from the workflows altogether: https://github.com/actions-rust-lang/setup-rust-toolchain?tab=readme-ov-file#inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4382
Release Hermes v.1.13.2
⚡
Cargo.lockunclogrc) version, then skip theunclog releasestepReassign unfinished issues of previous milestone to the next milestoneNotify the comms team about the pending new release by tagging @isa-belch as a reviewer here